Mantis Bug Tracker

View Issue DetailsJump to Notes ] Wiki ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000011jquantlib[All Projects] testspublic2008-12-15 23:292009-02-08 15:31
ReporterAdministrator 
Assigned ToUeli Hofstetter 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version0.1.2Fixed in Version0.1.2 
Summary0000011: Write test case on BilinearInterpolation
DescriptionWrite test case on BilinearInterpolation
TagsNo tags attached.
Attached Files? file icon BilinearInterpolationTest.java [^] (3,202 bytes) 2009-02-05 20:55

- Relationships
child of 0000141resolvedRichard Gomes Review interpolation classes 

-  Notes
(0000122)
Ueli Hofstetter (developer)
2009-02-05 20:49
edited on: 2009-02-05 20:56

see notes /attach.

(0000126)
Richard Gomes (manager)
2009-02-06 02:37

Ueli,

1. Could you please remove "static" from fields which cannot be considered constant, like zz, tolerance and interpolation2d?

2. interpolation2d and tolerance could be "final" and, in fact, they can be initialized by the constructor.

3. setUpLinearInterpolation contents could be moved to the constructor... and it ends up getting rid of @BeforeClass

Please commit to SVN.

Note: As you can see, I dont like "static" very much... for very good reasons. I need to write an article in our wiki about it. In your code, it's not critical at all. I requested these changes only to heads up that we need to remember to avoid static data/code.

Cheers :)
(0000129)
Ueli Hofstetter (developer)
2009-02-06 10:59

hi,

i copy-pasted the sceleton from the other interpolation testcases where tolerance etc. are static as well, that's why it is as it is ;-)

i will check the other interpolation testcases as well.

cheers

ueli
(0000132)
Richard Gomes (manager)
2009-02-06 11:31

wow! excellent.
Well done, man!

- Issue History
Date Modified Username Field Change
2008-12-15 23:29 Administrator New Issue
2009-01-25 22:42 Richard Gomes Target Version => 0.1.2
2009-01-25 23:43 Richard Gomes Relationship added child of 0000141
2009-02-04 01:15 Ueli Hofstetter Status new => assigned
2009-02-04 01:15 Ueli Hofstetter Assigned To => Ueli Hofstetter
2009-02-05 20:49 Ueli Hofstetter Note Added: 0000122
2009-02-05 20:49 Ueli Hofstetter Status assigned => resolved
2009-02-05 20:49 Ueli Hofstetter Resolution open => fixed
2009-02-05 20:54 Ueli Hofstetter Status resolved => feedback
2009-02-05 20:54 Ueli Hofstetter Resolution fixed => reopened
2009-02-05 20:55 Ueli Hofstetter File Added: BilinearInterpolationTest.java
2009-02-05 20:56 Ueli Hofstetter Note Edited: 0000122
2009-02-05 20:57 Ueli Hofstetter Status feedback => assigned
2009-02-05 20:57 Ueli Hofstetter Assigned To Ueli Hofstetter => Richard Gomes
2009-02-06 02:34 Richard Gomes Issue Monitored: Dominik Holenstein
2009-02-06 02:37 Richard Gomes Note Added: 0000126
2009-02-06 02:37 Richard Gomes Assigned To Richard Gomes => Ueli Hofstetter
2009-02-06 10:59 Ueli Hofstetter Note Added: 0000129
2009-02-06 11:01 Ueli Hofstetter Assigned To Ueli Hofstetter => Richard Gomes
2009-02-06 11:31 Richard Gomes Note Added: 0000132
2009-02-06 11:31 Richard Gomes Assigned To Richard Gomes => Ueli Hofstetter
2009-02-08 15:30 Richard Gomes Status assigned => resolved
2009-02-08 15:30 Richard Gomes Fixed in Version => 0.1.2
2009-02-08 15:30 Richard Gomes Resolution reopened => fixed
2009-02-08 15:31 Richard Gomes Issue Monitored: Ueli Hofstetter


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker