0000188: Review org.jquantlib.time.TimeGrid

View Issue Details[ Jump to Notes ] [ Wiki ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0000188

jquantlib

[All Projects] code review

public

2009-02-10 15:14

2009-06-18 01:40

Reporter

Richard Gomes

Assigned To

Richard Gomes

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

0.1.2

Fixed in Version

0.1.2

Summary

0000188: Review org.jquantlib.time.TimeGrid

Description

Please review

        public double end() /*@Readonly*/ {
            return times_.lastIndexOf(mandatoryTimes_);
        }

High Priority Correctness [H C GC] No relationship between generic parameter and method argument [GC_UNRELATED_TYPES]
In class org.jquantlib.time.TimeGrid
In method org.jquantlib.time.TimeGrid.end()
Actual type it.unimi.dsi.fastutil.doubles.DoubleArrayList<java.lang.Double>
Expected Double
Called method java.util.List.lastIndexOf(Object)
Invoked on org.jquantlib.time.TimeGrid.times_
org.jquantlib.time.TimeGrid.mandatoryTimes_ passed as argument
it.unimi.dsi.fastutil.doubles.AbstractDoubleList.equals(Object) used to determine equality
At TimeGrid.java:[line 340]

[H C GC] No relationship between generic parameter and method argument [GC_UNRELATED_TYPES]

This call to a generic collection method contains an argument with an incompatible class from that of the collection's parameter (i.e., the type of the argument is neither a supertype nor a subtype of the corresponding generic type argument). Therefore, it is unlikely that the collection contains any objects that are equal to the method argument used here. Most likely, the wrong value is being passed to the

Tags

No tags attached.

Attached Files

Relationships

Notes
(0000231) Richard Gomes (manager) 2009-03-07 22:37	I've done a full code review on TimeGrid which ended up solving this issue too.

(0000341) Richard Gomes (manager) 2009-06-18 01:40	done

Issue History
Date Modified	Username	Field	Change
2009-02-10 15:14	Richard Gomes	New Issue
2009-02-10 15:14	Richard Gomes	Status	new => assigned
2009-02-10 15:14	Richard Gomes	Assigned To	=> Dominik Holenstein
2009-03-07 22:36	Richard Gomes	Assigned To	Dominik Holenstein => Richard Gomes
2009-03-07 22:37	Richard Gomes	Note Added: 0000231
2009-03-07 22:37	Richard Gomes	Status	assigned => resolved
2009-03-07 22:37	Richard Gomes	Fixed in Version	=> 0.1.2
2009-03-07 22:37	Richard Gomes	Resolution	open => fixed
2009-06-18 01:40	Richard Gomes	Note Added: 0000341
2009-06-18 01:40	Richard Gomes	Status	resolved => closed