| Anonymous | Login | 2010-09-08 18:04 BST | ![]() |
| Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki |
| View Issue Details[ Jump to Notes ] [ Wiki ] | [ Issue History ] [ Print ] | |||||
| ID | Project | Category | View Status | Date Submitted | Last Update | |
| 0000086 | jquantlib | [All Projects] code review | public | 2008-12-28 00:19 | 2009-11-01 00:31 | |
| Reporter | Richard Gomes | |||||
| Assigned To | Zahid Hussain | |||||
| Priority | normal | Severity | minor | Reproducibility | have not tried | |
| Status | resolved | Resolution | fixed | |||
| Platform | OS | OS Version | ||||
| Product Version | ||||||
| Target Version | 0.1.3 | Fixed in Version | 0.1.3 | |||
| Summary | 0000086: Review Saudi Arabia calendar as it has suspicious code | |||||
| Description | In spite islamic calendar can be considered uncertain, according to links reported here, the current code in SaudiArabia.java has suspicious code which tests only 2004 and 2005. The code must be changed according to reliable official sources of information. http://www.saudicommercialoffice.comcalendar_and_public_holidays.html [^] http://www.phys.uu.nl/~vgent/islam/ummalqura.htm [^] http://www.tondering.dk/claus/cal/node6.html [^] | |||||
| Tags | No tags attached. | |||||
| Attached Files | ||||||
Relationships |
||||||
|
||||||
Notes |
|
|
(0000283) Richard Gomes (manager) 2009-03-21 12:59 |
I've done some cosmetic changes in order to make it look like other calendars. This class needs a complete code review, specially because Islamic calendar is absolutely uncertain. Holidays are determined by visual observation of natural events, like the full moon after another uncertain holiday. The visual observation can be affected by a cloudy weather and it changes the outcome of it. For this reason, past years must be verified against some reliable source. Current and future years need to be reviewed. |
|
(0000606) Richard Gomes (manager) 2009-11-01 00:24 |
Can this issue be marked as RESOLVED ? Thanks |
|
(0000614) Richard Gomes (manager) 2009-11-01 00:31 |
yes, can be marked as resolved! :) done |
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2008-12-28 00:19 | Richard Gomes | New Issue | |
| 2008-12-28 00:19 | Richard Gomes | Issue Monitored: Renjith Nair | |
| 2008-12-28 00:19 | Richard Gomes | Issue Monitored: Richard Gomes | |
| 2009-01-25 22:45 | Richard Gomes | Target Version | => 0.1.2 |
| 2009-01-25 23:33 | Richard Gomes | Relationship added | child of 0000043 |
| 2009-01-26 23:51 | Richard Gomes | Status | new => assigned |
| 2009-01-26 23:51 | Richard Gomes | Assigned To | => Richard Gomes |
| 2009-03-21 12:59 | Richard Gomes | Note Added: 0000283 | |
| 2009-03-21 12:59 | Richard Gomes | Target Version | 0.1.2 => 0.1.3 |
| 2009-03-27 21:18 | Richard Gomes | Priority | urgent => normal |
| 2009-11-01 00:24 | Richard Gomes | Note Added: 0000606 | |
| 2009-11-01 00:24 | Richard Gomes | Assigned To | Richard Gomes => Zahid Hussain |
| 2009-11-01 00:24 | Richard Gomes | Status | assigned => feedback |
| 2009-11-01 00:31 | Richard Gomes | Issue Monitored: Zahid Hussain | |
| 2009-11-01 00:31 | Richard Gomes | Note Added: 0000614 | |
| 2009-11-01 00:31 | Richard Gomes | Status | feedback => resolved |
| 2009-11-01 00:31 | Richard Gomes | Fixed in Version | => 0.1.3 |
| 2009-11-01 00:31 | Richard Gomes | Resolution | open => fixed |
| Copyright © 2000 - 2009 MantisBT Group |